Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add reproducible builds by building through GitHub actions #417

Merged

Conversation

tomudding
Copy link
Member

Description

This allows us to automatically publish :development, :latest, and :<version> tags of the various Docker images. The :development image is created automatically when changes are pushed to main. The :latest / :<version> image is created automatically as soon as a version is tagged.

Tested extensively over at https://github.com/GEWIS/gewisweb.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation improvement (no changes to code)
  • Other (please specify)

@tomudding tomudding requested a review from rinkp June 23, 2024 13:10
This allows us to automatically publish `:development`, `:latest`, and
`:<version>` tags of the various Docker images. The `:development` image is
created automatically when changes are pushed to `main`. The `:latest` /
`:<version>` image is created automatically as soon as a version is tagged.
@tomudding tomudding force-pushed the feature/automatic-docker-image-building branch from 7ed7603 to 521a0ea Compare June 23, 2024 14:12
@tomudding
Copy link
Member Author

Changes from 7ed7603 to 521a0ea are for GEWIS/gewisweb#1848.

@tomudding
Copy link
Member Author

We will have to figure out what our first tagged version will be, but I suggest using v3.0.0 as v2.0.0 was when we switched to Docker.

@rinkp rinkp merged commit 30ef138 into GEWIS:main Jul 1, 2024
4 checks passed
github-actions bot added a commit that referenced this pull request Jul 1, 2024
Rink: Merge pull request #417 from tomudding/feature/automatic-docker-image-building

Add reproducible builds by building through GitHub actions

Co-authored-by: rinkp <rinkp@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants